From 2ed0436c217501d5d8b48df123ef5b6b91fab4f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BC=A0=E9=80=B8=E7=BE=A4?= <875977494@qq.com> Date: Sat, 26 Jul 2025 01:18:00 +0800 Subject: [PATCH] fix: update DockerVMManager method signatures for interface compatibility (#287) - Fix delete_vm() method to accept region and **kwargs parameters - Fix occupy_vm() method to accept pid, region and **kwargs parameters - Ensures consistency with base VMManager interface and other providers - Resolves runtime argument mismatch errors when calling these methods This maintains backward compatibility while fixing the interface contract. --- desktop_env/providers/docker/manager.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/desktop_env/providers/docker/manager.py b/desktop_env/providers/docker/manager.py index 01fc096..8e400e8 100644 --- a/desktop_env/providers/docker/manager.py +++ b/desktop_env/providers/docker/manager.py @@ -99,7 +99,8 @@ class DockerVMManager(VMManager): def check_and_clean(self): pass - def delete_vm(self, vm_path): + def delete_vm(self, vm_path, region=None, **kwargs): + # Fixed: Added region and **kwargs parameters for interface compatibility pass def initialize_registry(self): @@ -108,7 +109,8 @@ class DockerVMManager(VMManager): def list_free_vms(self): return os.path.join(VMS_DIR, DOWNLOADED_FILE_NAME) - def occupy_vm(self, vm_path): + def occupy_vm(self, vm_path, pid, region=None, **kwargs): + # Fixed: Added pid, region and **kwargs parameters for interface compatibility pass def get_vm_path(self, os_type, region, screen_size=(1920, 1080), **kwargs):