fix: standardize provider interface parameters across all implementations
- Add screen_size parameter to get_vm_path() for all providers (with default 1920x1080) - Add os_type parameter to start_emulator() for Azure and VirtualBox providers - Add region parameter to stop_emulator() for VMware, Docker, and VirtualBox providers - Use *args, **kwargs for better extensibility and parameter consistency - Add documentation comments explaining ignored parameters for interface consistency - Prevents TypeError exceptions when AWS-specific parameters are passed to other providers This ensures all providers can handle the same parameter sets while maintaining backward compatibility and avoiding interface fragmentation.
This commit is contained in:
@@ -428,7 +428,9 @@ class VirtualBoxVMManager(VMManager):
|
||||
free_vms.append((vm_path, pid_str))
|
||||
return free_vms
|
||||
|
||||
def get_vm_path(self, os_type, region=None):
|
||||
def get_vm_path(self, os_type, region=None, screen_size=(1920, 1080), **kwargs):
|
||||
# Note: screen_size parameter is ignored for VirtualBox provider
|
||||
# but kept for interface consistency with other providers
|
||||
if os_type != "Ubuntu":
|
||||
raise ValueError("Only support Ubuntu for now.")
|
||||
|
||||
|
||||
@@ -55,7 +55,9 @@ class VirtualBoxProvider(Provider):
|
||||
logger.error(f"Error executing command: {e.output.decode().strip()}")
|
||||
|
||||
|
||||
def start_emulator(self, path_to_vm: str, headless: bool):
|
||||
def start_emulator(self, path_to_vm: str, headless: bool, os_type: str = None, *args, **kwargs):
|
||||
# Note: os_type parameter is ignored for VirtualBox provider
|
||||
# but kept for interface consistency with other providers
|
||||
logger.info("Starting VirtualBox VM...")
|
||||
|
||||
while True:
|
||||
@@ -113,7 +115,9 @@ class VirtualBoxProvider(Provider):
|
||||
time.sleep(WAIT_TIME) # Wait for the VM to revert
|
||||
return path_to_vm
|
||||
|
||||
def stop_emulator(self, path_to_vm: str):
|
||||
def stop_emulator(self, path_to_vm: str, region=None, *args, **kwargs):
|
||||
# Note: region parameter is ignored for VirtualBox provider
|
||||
# but kept for interface consistency with other providers
|
||||
logger.info("Stopping VirtualBox VM...")
|
||||
uuid = VirtualBoxProvider._get_vm_uuid(path_to_vm)
|
||||
VirtualBoxProvider._execute_command(["VBoxManage", "controlvm", uuid, "savestate"])
|
||||
|
||||
Reference in New Issue
Block a user