From 71e9a1ead8a536314c6061d6be3fa6f693d9f435 Mon Sep 17 00:00:00 2001 From: adlsdztony Date: Fri, 6 Jun 2025 09:08:14 +0000 Subject: [PATCH] fix&refactor: improve error handling in download process and enhance start_emulator method signature --- desktop_env/controllers/setup.py | 2 +- desktop_env/providers/aws/provider_with_proxy.py | 2 +- run_multienv_openaicua.py | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/desktop_env/controllers/setup.py b/desktop_env/controllers/setup.py index dc8a6ae..daf4fe6 100644 --- a/desktop_env/controllers/setup.py +++ b/desktop_env/controllers/setup.py @@ -121,7 +121,7 @@ class SetupController: logger.error( f"Failed to download {url} caused by {e}. Retrying... ({max_retries - i - 1} attempts left)") if not downloaded: - raise requests.RequestException(f"Failed to download {url}. No retries left. Error: {e}") + raise requests.RequestException(f"Failed to download {url}. No retries left.") form = MultipartEncoder({ "file_path": path, diff --git a/desktop_env/providers/aws/provider_with_proxy.py b/desktop_env/providers/aws/provider_with_proxy.py index 9472433..d7cfa0e 100644 --- a/desktop_env/providers/aws/provider_with_proxy.py +++ b/desktop_env/providers/aws/provider_with_proxy.py @@ -113,7 +113,7 @@ echo "$(date): Configured proxy {self.current_proxy.host}:{self.current_proxy.po else: return f"{proxy.protocol}://{proxy.host}:{proxy.port}" - def start_emulator(self, path_to_vm: str, headless: bool): + def start_emulator(self, path_to_vm: str, headless: bool, *args, **kwargs): logger.info("Starting AWS VM with proxy configuration...") ec2_client = boto3.client('ec2', region_name=self.region) diff --git a/run_multienv_openaicua.py b/run_multienv_openaicua.py index 155826d..65464d0 100644 --- a/run_multienv_openaicua.py +++ b/run_multienv_openaicua.py @@ -237,7 +237,9 @@ def run_env_tasks(env_idx: int, env_tasks: dict, args: argparse.Namespace, share shared_scores, ) except Exception as e: + import traceback logger.error(f"Exception in Env{env_idx+1} {domain}/{example_id}: {e}") + logger.error(traceback.format_exc()) try: env.controller.end_recording( os.path.join(example_result_dir, "recording.mp4")