From 5d184a78115f1c5c77ade1767d67beb72f4a988e Mon Sep 17 00:00:00 2001 From: Remi Cadene Date: Tue, 18 Mar 2025 16:55:08 +0000 Subject: [PATCH] NIT --- examples/port_datasets/droid_rlds/README.md | 2 +- examples/port_datasets/droid_rlds/slurm_aggregate_shards.py | 2 +- examples/port_datasets/droid_rlds/slurm_upload.py | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/port_datasets/droid_rlds/README.md b/examples/port_datasets/droid_rlds/README.md index 6d426dcc..11020d09 100644 --- a/examples/port_datasets/droid_rlds/README.md +++ b/examples/port_datasets/droid_rlds/README.md @@ -135,7 +135,7 @@ Run this script to start uploading: python examples/port_datasets/droid_rlds/slurm_upload.py \ --repo-id your_id/droid_1.0.1 \ --logs-dir /your/logs \ - --job-name aggr_droid \ + --job-name upload_droid \ --partition your_partition \ --workers 50 \ --cpus-per-task 4 \ diff --git a/examples/port_datasets/droid_rlds/slurm_aggregate_shards.py b/examples/port_datasets/droid_rlds/slurm_aggregate_shards.py index ad8593a7..621b3600 100644 --- a/examples/port_datasets/droid_rlds/slurm_aggregate_shards.py +++ b/examples/port_datasets/droid_rlds/slurm_aggregate_shards.py @@ -241,7 +241,7 @@ def main(): parser.add_argument( "--job-name", type=str, - default="port_droid", + default="aggr_droid", help="Job name used in slurm, and name of the directory created inside the provided logs directory.", ) parser.add_argument( diff --git a/examples/port_datasets/droid_rlds/slurm_upload.py b/examples/port_datasets/droid_rlds/slurm_upload.py index 27f0c8dd..f7f03716 100644 --- a/examples/port_datasets/droid_rlds/slurm_upload.py +++ b/examples/port_datasets/droid_rlds/slurm_upload.py @@ -186,7 +186,7 @@ def main(): parser.add_argument( "--job-name", type=str, - default="port_droid", + default="upload_droid", help="Job name used in slurm, and name of the directory created inside the provided logs directory.", ) parser.add_argument( @@ -198,7 +198,7 @@ def main(): parser.add_argument( "--workers", type=int, - default=2048, + default=50, help="Number of slurm workers. It should be less than the maximum number of shards.", ) parser.add_argument( @@ -209,7 +209,7 @@ def main(): parser.add_argument( "--cpus-per-task", type=int, - default=8, + default=4, help="Number of cpus that each slurm worker will use.", ) parser.add_argument(