tangger/lerobot
1
0
Fork 1
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixes failed to delete images because the timing of gc is uncertain (#1710)

Browse Source 
* Prevents resource leak in video_utils when getting width and height

Added the with statement when opening the image to ensure that the file handle is properly closed after its contents are read. 
Otherwise, shutil.rmtree(img_dir) will fail when called after the encode_video_frames function completes.

Signed-off-by: Lycoris <32864669+lycoris1129@users.noreply.github.com>

---------

Signed-off-by: Lycoris <32864669+lycoris1129@users.noreply.github.com>
This commit is contained in:
Lycoris
2025-10-18 12:47:07 +08:00
committed by GitHub
parent da5d2f3e91
commit f0aeded142
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/lerobot/datasets/video_utils.py
View File

@@ -342,8 +342,8 @@ def encode_video_frames(
# Define video output frame size (assuming all input frames are the same size) # Define video output frame size (assuming all input frames are the same size)
if len(input_list) == 0: if len(input_list) == 0:
raise FileNotFoundError(f"No images found in {imgs_dir}.") raise FileNotFoundError(f"No images found in {imgs_dir}.")
dummy_image = Image.open(input_list[0]) with Image.open(input_list[0]) as dummy_image:
width, height = dummy_image.size width, height = dummy_image.size
# Define video codec options # Define video codec options
video_options = {} video_options = {}
@@ -373,11 +373,12 @@ def encode_video_frames(
# Loop through input frames and encode them # Loop through input frames and encode them
for input_data in input_list: for input_data in input_list:
input_image = Image.open(input_data).convert("RGB") with Image.open(input_data) as input_image:
input_frame = av.VideoFrame.from_image(input_image) input_image = input_image.convert("RGB")
packet = output_stream.encode(input_frame) input_frame = av.VideoFrame.from_image(input_image)
if packet: packet = output_stream.encode(input_frame)
output.mux(packet) if packet:
output.mux(packet)
# Flush the encoder # Flush the encoder
packet = output_stream.encode() packet = output_stream.encode()