* Enhance OpenCVCamera with FOURCC support and validation - Added FOURCC configuration option to OpenCVCamera and OpenCVCameraConfig for specifying video format. - Implemented _validate_fourcc method to validate and set the camera's FOURCC code. - Updated _configure_capture_settings to apply FOURCC settings before FPS and resolution. - Enhanced camera detection to include default FOURCC code in camera info. - Updated documentation to reflect new FOURCC parameter and its implications on performance. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add tests for FOURCC configuration in OpenCVCamera - Implemented tests to validate FOURCC configuration and its application in OpenCVCamera. - Added checks for valid FOURCC codes and ensured that invalid codes raise appropriate errors. - Included a test for camera connection functionality using specified FOURCC settings. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix circular import in __init__.py - change to relative import * Update src/lerobot/cameras/opencv/configuration_opencv.py Co-authored-by: Steven Palma <imstevenpmwork@ieee.org> Signed-off-by: hls <56255627+forgetwhatuwant@users.noreply.github.com> * Update src/lerobot/cameras/opencv/configuration_opencv.py Co-authored-by: Steven Palma <imstevenpmwork@ieee.org> Signed-off-by: hls <56255627+forgetwhatuwant@users.noreply.github.com> * fix(camera_opencv): ensure MSMF hardware transform compatibility on Windows before importing OpenCV * This change reverts the import from a relative import (.) back to the absolute import (lerobot.) as it was previously * opencv/config: satisfy Ruff SIM102 by merging nested if for fourcc validation * style(opencv/config): apply ruff-format changes --------- Signed-off-by: hls <56255627+forgetwhatuwant@users.noreply.github.com> Signed-off-by: Steven Palma <imstevenpmwork@ieee.org> Co-authored-by: forgetwhatuwant <forgetwhatuwant@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
229 lines
7.0 KiB
Python
229 lines
7.0 KiB
Python
#!/usr/bin/env python
|
|
|
|
# Copyright 2024 The HuggingFace Inc. team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# Example of running a specific test:
|
|
# ```bash
|
|
# pytest tests/cameras/test_opencv.py::test_connect
|
|
# ```
|
|
|
|
from pathlib import Path
|
|
|
|
import numpy as np
|
|
import pytest
|
|
|
|
from lerobot.cameras.configs import Cv2Rotation
|
|
from lerobot.cameras.opencv import OpenCVCamera, OpenCVCameraConfig
|
|
from lerobot.utils.errors import DeviceAlreadyConnectedError, DeviceNotConnectedError
|
|
|
|
# NOTE(Steven): more tests + assertions?
|
|
TEST_ARTIFACTS_DIR = Path(__file__).parent.parent / "artifacts" / "cameras"
|
|
DEFAULT_PNG_FILE_PATH = TEST_ARTIFACTS_DIR / "image_160x120.png"
|
|
TEST_IMAGE_SIZES = ["128x128", "160x120", "320x180", "480x270"]
|
|
TEST_IMAGE_PATHS = [TEST_ARTIFACTS_DIR / f"image_{size}.png" for size in TEST_IMAGE_SIZES]
|
|
|
|
|
|
def test_abc_implementation():
|
|
"""Instantiation should raise an error if the class doesn't implement abstract methods/properties."""
|
|
config = OpenCVCameraConfig(index_or_path=0)
|
|
|
|
_ = OpenCVCamera(config)
|
|
|
|
|
|
def test_connect():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
|
|
camera.connect(warmup=False)
|
|
|
|
assert camera.is_connected
|
|
|
|
|
|
def test_connect_already_connected():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
with pytest.raises(DeviceAlreadyConnectedError):
|
|
camera.connect(warmup=False)
|
|
|
|
|
|
def test_connect_invalid_camera_path():
|
|
config = OpenCVCameraConfig(index_or_path="nonexistent/camera.png")
|
|
camera = OpenCVCamera(config)
|
|
|
|
with pytest.raises(ConnectionError):
|
|
camera.connect(warmup=False)
|
|
|
|
|
|
def test_invalid_width_connect():
|
|
config = OpenCVCameraConfig(
|
|
index_or_path=DEFAULT_PNG_FILE_PATH,
|
|
width=99999, # Invalid width to trigger error
|
|
height=480,
|
|
)
|
|
camera = OpenCVCamera(config)
|
|
|
|
with pytest.raises(RuntimeError):
|
|
camera.connect(warmup=False)
|
|
|
|
|
|
@pytest.mark.parametrize("index_or_path", TEST_IMAGE_PATHS, ids=TEST_IMAGE_SIZES)
|
|
def test_read(index_or_path):
|
|
config = OpenCVCameraConfig(index_or_path=index_or_path)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
img = camera.read()
|
|
|
|
assert isinstance(img, np.ndarray)
|
|
|
|
|
|
def test_read_before_connect():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
|
|
with pytest.raises(DeviceNotConnectedError):
|
|
_ = camera.read()
|
|
|
|
|
|
def test_disconnect():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
camera.disconnect()
|
|
|
|
assert not camera.is_connected
|
|
|
|
|
|
def test_disconnect_before_connect():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
|
|
with pytest.raises(DeviceNotConnectedError):
|
|
_ = camera.disconnect()
|
|
|
|
|
|
@pytest.mark.parametrize("index_or_path", TEST_IMAGE_PATHS, ids=TEST_IMAGE_SIZES)
|
|
def test_async_read(index_or_path):
|
|
config = OpenCVCameraConfig(index_or_path=index_or_path)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
try:
|
|
img = camera.async_read()
|
|
|
|
assert camera.thread is not None
|
|
assert camera.thread.is_alive()
|
|
assert isinstance(img, np.ndarray)
|
|
finally:
|
|
if camera.is_connected:
|
|
camera.disconnect() # To stop/join the thread. Otherwise get warnings when the test ends
|
|
|
|
|
|
def test_async_read_timeout():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
try:
|
|
with pytest.raises(TimeoutError):
|
|
camera.async_read(timeout_ms=0)
|
|
finally:
|
|
if camera.is_connected:
|
|
camera.disconnect()
|
|
|
|
|
|
def test_async_read_before_connect():
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH)
|
|
camera = OpenCVCamera(config)
|
|
|
|
with pytest.raises(DeviceNotConnectedError):
|
|
_ = camera.async_read()
|
|
|
|
|
|
def test_fourcc_configuration():
|
|
"""Test FourCC configuration validation and application."""
|
|
|
|
# Test MJPG specifically (main use case)
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH, fourcc="MJPG")
|
|
camera = OpenCVCamera(config)
|
|
assert camera.config.fourcc == "MJPG"
|
|
|
|
# Test a few other common formats
|
|
valid_fourcc_codes = ["YUYV", "YUY2", "RGB3"]
|
|
|
|
for fourcc in valid_fourcc_codes:
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH, fourcc=fourcc)
|
|
camera = OpenCVCamera(config)
|
|
assert camera.config.fourcc == fourcc
|
|
|
|
# Test invalid FOURCC codes
|
|
invalid_fourcc_codes = ["ABC", "ABCDE", ""]
|
|
|
|
for fourcc in invalid_fourcc_codes:
|
|
with pytest.raises(ValueError):
|
|
OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH, fourcc=fourcc)
|
|
|
|
|
|
def test_fourcc_with_camera():
|
|
"""Test FourCC functionality with actual camera connection."""
|
|
config = OpenCVCameraConfig(index_or_path=DEFAULT_PNG_FILE_PATH, fourcc="MJPG")
|
|
camera = OpenCVCamera(config)
|
|
|
|
# Connect should work with MJPG specified
|
|
camera.connect(warmup=False)
|
|
assert camera.is_connected
|
|
|
|
# Read should work normally
|
|
img = camera.read()
|
|
assert isinstance(img, np.ndarray)
|
|
|
|
camera.disconnect()
|
|
|
|
|
|
@pytest.mark.parametrize("index_or_path", TEST_IMAGE_PATHS, ids=TEST_IMAGE_SIZES)
|
|
@pytest.mark.parametrize(
|
|
"rotation",
|
|
[
|
|
Cv2Rotation.NO_ROTATION,
|
|
Cv2Rotation.ROTATE_90,
|
|
Cv2Rotation.ROTATE_180,
|
|
Cv2Rotation.ROTATE_270,
|
|
],
|
|
ids=["no_rot", "rot90", "rot180", "rot270"],
|
|
)
|
|
def test_rotation(rotation, index_or_path):
|
|
filename = Path(index_or_path).name
|
|
dimensions = filename.split("_")[-1].split(".")[0] # Assumes filenames format (_wxh.png)
|
|
original_width, original_height = map(int, dimensions.split("x"))
|
|
|
|
config = OpenCVCameraConfig(index_or_path=index_or_path, rotation=rotation)
|
|
camera = OpenCVCamera(config)
|
|
camera.connect(warmup=False)
|
|
|
|
img = camera.read()
|
|
assert isinstance(img, np.ndarray)
|
|
|
|
if rotation in (Cv2Rotation.ROTATE_90, Cv2Rotation.ROTATE_270):
|
|
assert camera.width == original_height
|
|
assert camera.height == original_width
|
|
assert img.shape[:2] == (original_width, original_height)
|
|
else:
|
|
assert camera.width == original_width
|
|
assert camera.height == original_height
|
|
assert img.shape[:2] == (original_height, original_width)
|